search

openwallet-foundation / credo-ts-ext

Extension libraries for Credo
https://credo.js.org
Apache License 2.0
29 stars 37 forks source link

[rest] no peer dependencies #142

Closed jakubkoci closed 2 years ago

jakubkoci commented 2 years ago

"Starting Own Server" section in docs mentions "To get started, make sure you have set up the correct version of Aries Framework JavaScript" with the following command:

npm info "@aries-framework/rest" peerDependencies

But that command doesn't return anything. I wanted to use the extension with the framework, but I was a bit confused about what exact version of framework is compatible? It is the version 0.1.0?

TimoGlastra commented 2 years ago

Ah I think we moved away from peer dependencies as you can now also use the rest package as cli, in which case you won't install the node/core packages yourself. We should probably remove this from the README

Are you willing to open a PR for this?

But yes, the current supported version is 0.1.0 (we should probably also add that to the readme!).

@amanji has been working on 0.2.0 support, but not sure on the status of that

amanji commented 2 years ago

Sorry this took a bit of a backseat to work on updates to Bifold. Will continue working on this. If it is just an update to the readme and removing the npm package, I can do that along with the REST API update.

TimoGlastra commented 2 years ago

Yes It's just an update to the readme. That would be appreciated, thanks!