Closed TimoGlastra closed 1 year ago
- [ ] Should all cheqd sdk related items be added to a single package (something
@aries-framework/cheqd-sdk
) or should we group it by feature (something like@aries-framework/cheqd-sdk-did-provider
that exports the did resolver + registrar)?
Apart from resolver and registrar, what are the other cheqd-specific packages you can foresee? I think that at least the resolver package should be separated from the rest, as I imagine it will be the one imported by most projects . BTW I'm curious about the 'cheqd-sdk' prefix on these packages: wouldn't it suffice with 'cheqd-*'?
- [ ] How do we configure the did resolver with the right rpc urls? We have configuration for modules, but as this is added as a class (not instance) to the
DidsModule.resolvers
class. I see a few solutions:
I think the second approach is a lot better. Several resolvers would need to be parameterized and in my opinion passing the instance will be easier for most developers. Probably there are more elegant solutions by using dependency injection magic as well, but not everyone is familiarized with this concept and would complicate the things a bit more.
Not sure about React Native but this has been implemented in https://github.com/hyperledger/aries-framework-javascript/pull/1334
Create a
CheqdSdkDidResolver
that implements theDidResolver
interface from AFJ.Code Example
Todo
CheqdSdkDidResolver
class and export it from a custom cheqd packageQuestions
@aries-framework/cheqd-sdk
) or should we group it by feature (something like@aries-framework/cheqd-sdk-did-provider
that exports the did resolver + registrar)?CheqdSdkAnonCredsResource
, which will depend on the anoncreds package for afj)DidsModule.resolvers
class. I see a few solutions:CheqdSdkModuleConfig
-- or whatever it will be called) and extract the config from it.resolve
method on the resolver is called (I think this has my preference).Configuration options:
1.
2.