search

openwallet-foundation / credo-ts

Typescript framework for building decentralized identity and verifiable credential solutions
https://credo.js.org
Apache License 2.0
262 stars 199 forks source link

Enable toggling of return route (true, false) during credential issuance and present proof flows #1261

Open NB-MikeRichardson opened 1 year ago

NB-MikeRichardson commented 1 year ago

During a connectionless proof request, the wallet has to wait for a network timeout as the request has return route set to true. This slows the user experience as the proof is accepted while the wallet spinner continues for another 10 seconds or so.

A similar fix was put in place for connection to the mediator on wallet initiation. It may make sense to implement this as a generic solution. Will leave that up to the AFJ community to discuss.

TimoGlastra commented 1 year ago

Relevant PR in ACA-Py for why this is happening with ACA-Py agents: https://github.com/hyperledger/aries-cloudagent-python/pull/1853

NB-MikeRichardson commented 1 year ago

This can be closed now

TimoGlastra commented 1 year ago

It hasn't been merged yet, right?

NB-MikeRichardson commented 1 year ago

Sorry I thought this was merged.

I have created a new PR as the previous one was broken by recent changes; it was quicker to redo the changes in a new branch

From: Timo Glastra @.> Sent: Monday, February 20, 2023 11:14 AM To: hyperledger/aries-framework-javascript @.> Cc: Mike Richardson @.>; Author @.> Subject: Re: [hyperledger/aries-framework-javascript] Enable toggling of return route (true, false) during credential issuance and present proof flows (Issue #1261)

It hasn't been merged yet, right?

— Reply to this email directly, view it on GitHubhttps://github.com/hyperledger/aries-framework-javascript/issues/1261#issuecomment-1436772047, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWM6GLI5CPM7KQHRQN3E5Q3WYNGYHANCNFSM6AAAAAAUP7PAOA. You are receiving this because you authored the thread.Message ID: @.***>