openwallet-foundation / credo-ts

Typescript framework for building decentralized identity and verifiable credential solutions
https://credo.js.org
Apache License 2.0
276 stars 202 forks source link

Update master secret to link secret #1410

Closed TimoGlastra closed 1 year ago

TimoGlastra commented 1 year ago
          When you call create credential request in indy-sdk / anoncreds rs) it will return the following metadata:
{
          "master_secret_blinding_data": {
            "v_prime": "6088566065720309491695644944398283228337587174153857313170975821102428665682789111613194763354086540665993822078019981371868225077833338619179176775427438467982451441607103798898879602785159234518625137830139620180247716943526165654371269235270542103763086097868993123576876140373079243750364373248313759006451117374448224809216784667062369066076812328680472952148248732117690061334364498707450807760707599232005951883007442927332478453073050250159545354197772368724822531644722135760544102661829321297308144745035201971564171469931191452967102169235498946760810509797149446495254099095221645804379785022515460071863075055785600423275733199",
            "vr_prime": null
          },
          "nonce": "131502096406868204437821",
          "master_secret_name": "walletId28c602347-3f6e-429f-93cd-d5aa7856ef3f"
        }

If we move to using link secret in AnonCreds RS, we should update all metadata and transform the master_secret keys to link_secret keys in the Indy SDK holder service in AFJ.

Did you also update these fields in your link secret pr in anoncreds rs?

_Originally posted by @TimoGlastra in https://github.com/hyperledger/aries-framework-javascript/pull/1392#discussion_r1142293258_

TimoGlastra commented 1 year ago
  1. Release new version of AnonCreds Rust
  2. Update field names in AFJ
  3. handle difference between field names in indy-sdk (still master_secret) and anoncreds rs (link_secret). Probably extending the migration script to update indy-sdk generated request metadata to use link_secret, and from now in the indy-sdk when returning the credential request metadata we chagne the keys.
TimoGlastra commented 1 year ago

@TimoGlastra will make AnonCreds RS release, @genaris will integrate into AFJ