openwallet-foundation / credo-ts

Typescript framework for building decentralized identity and verifiable credential solutions
https://credo.js.org
Apache License 2.0
266 stars 200 forks source link

Wrong schema Id is stored for credentials #1874

Closed sairanjit closed 5 months ago

sairanjit commented 5 months ago

While storing the credential in wallet if thedid of schemaId and credDefId are different then the wallet uses the did of credDefId for schemaId.

From where can we use the same namespaceIdentifier for schemaId ?

TimoGlastra commented 5 months ago

Ah good catch. We should probably add tests where the schema creator is different from the cred def creator.

Would you be able to create a fix, and also add some tests?

sairanjit commented 5 months ago

Yeah Sure @TimoGlastra

pallavighule commented 5 months ago

@sairanjit @TimoGlastra I am looking into this . I will raise the PR soon