search

openwallet-foundation / credo-ts

Typescript framework for building decentralized identity and verifiable credential solutions
https://credo.js.org
Apache License 2.0
262 stars 199 forks source link

Fix repolinter issues #222

Open TimoGlastra opened 3 years ago

TimoGlastra commented 3 years ago

Hyperledger has some guidelines on repo structure. A report for Aries Framework JavaScript is available here:

https://github.com/ryjones/rl-report/blob/main/main/aries-framework-javascript-repolinter-report.md

We should try to fix these issues

shoebsd31 commented 3 years ago

Hi @TimoGlastra , can you please explain it a bit more. I see its already there in #223

TimoGlastra commented 3 years ago

Sure! PR #223 adds a github action to run the report that I linked to in this issue. However it does not fix any of the errors from the report. The action allows to check this on a regular basis on ourselves.

Do you want to work on this issue? I haven't taken a good look at the report, but maybe you're able to fix some of them.

Otherwise there's always other issues to work on :-)

shoebsd31 commented 3 years ago

OK i would love to try this out

shoebsd31 commented 3 years ago

@TimoGlastra I will need to wait for the pull-request to get merged

TimoGlastra commented 3 years ago

OK i would love to try this out

You got it!

@TimoGlastra I will need to wait for the pull-request to get merged

Why is that?

shoebsd31 commented 3 years ago

when the pull-request is merged with the master, I will rebase the master in my fork and update the workflow file.

TimoGlastra commented 3 years ago

Merged!

see https://github.com/hyperledger/aries-framework-javascript/runs/2260188889?check_suite_focus=true for the first run