search

openwallet-foundation / credo-ts

Typescript framework for building decentralized identity and verifiable credential solutions
https://credo.js.org
Apache License 2.0
271 stars 200 forks source link

Improve verifier checks in verifier service #570

Open TimoGlastra opened 2 years ago

TimoGlastra commented 2 years ago

Looking at ACA-Py they do quite some manual checks on the values of a proof and matches it to encoded values to make sure the proof hasn't been tampered with. We need to make sure to add these checks to AFJ, as I think this makes us vulnerable to tampering attacks.

I always assumed Indy would handle these checks.

https://github.com/hyperledger/aries-cloudagent-python/blob/main/aries_cloudagent/indy/verifier.py#L230

swcurran commented 2 years ago

I'm assuming you mean "add these checks to AFJ", right?

TimoGlastra commented 2 years ago

@swcurran Yes! 😁