search

openwallet-foundation / didcomm-mediator-service

36 stars 40 forks source link

feat: initial work on an AFJ mediator #61

Closed jleach closed 1 year ago

jleach commented 1 year ago

Initial work on creating a containerized AFJ mediator and supporting Kubernets deplouyment manifests.

swcurran commented 1 year ago

Approved based on @esune ’s comments. I’ll leave it to @jleach to decide to change anything based on the comments or to just merge this.

jleach commented 1 year ago
  • should the dist folder gitignored?

I think so.

  • any specific reason to use gulp vs tsc to compile to js code?

Gulp calls tsc and just runs some other tasks like making the /dist folder.

  • any advantage of using yarn over plain-old npm?

Its a convention in AFJ and Bifold. Just keeping things the same across all TS projects.

jleach commented 1 year ago

@swcurran Needs approval again. I made a few changes to make AFJ work in the .devcontainer, added node support so you can build in the devcontainer, and excluded /dist from the repo as per @esune feedback above.