search

openwallet-foundation / digital-wallet-and-agent-overviews-sig

The objective of this SIG is to develop and maintain the Digital Wallets and Agents Overview. The overview should provide transparency of the characteristics of wallets and agents in order to allow for an objective comparison and effective decision making on which wallet or agent is applicable for your use case.
https://openwallet-foundation.github.io/digital-wallet-and-agent-overviews-sig/
Apache License 2.0
13 stars 23 forks source link

added hightrust.id #60

Closed akolio closed 5 months ago

cre8 commented 5 months ago

Hi @akolio,

are you able to sign your commit so the DCO check can pass? Then we are able to merge your PR :)

akolio commented 5 months ago

Thanks @cre8! Luckily GitHub had straightforward steps to add the signoff.

samuelmr commented 5 months ago

I'm not opposed to adding Hightrust.id, but wondering why the entry is basically blank.

@akolio, is there a reason you didn't provide more information? If you're affiliated with Hightrust, it should be relatively easy for you to find out information about supported credential formats, signature algorithms, etc.

At least the urlWebsite would be nice (it's mandatory in the schema) so that the audience has a pointer on where to look for more information.

@cre8, I think we shouldn't accept blank entries. They provide very little value to the audience. I removed many entries from the previous iteration due to missing data.

akolio commented 5 months ago

We were planning on adding fields as we go. Company URL was added as CompanyUrl which is what the "add wallet" tool on https://openwallet-foundation.github.io/digital-wallet-and-agent-overviews-sig/ wanted. But I see it might be deprecated.

I noticed there were other differences in this json too compared to the ones on GitHub. E.g. there's no "linkToApp" (instead there are fields such as "urlAppStore", "urlGooglePlayStore" and "urlWebsite"). The add wallet tool might need a little refreshing 🙂

samuelmr commented 5 months ago

Thanks!

@cre8, will you check that the attributes in the add component correspond to the schema?

cre8 commented 5 months ago

@samuelmr I commented the check out since we had the old schemas included, see: https://github.com/openwallet-foundation/digital-wallet-and-agent-overviews-sig/blob/main/.github/workflows/main.yml#L41

I will add it again