openwallet-foundation / owl-agent-test-harness

Aries agent test framework, with agent backchannel support
https://aries-interop.info
Apache License 2.0
60 stars 66 forks source link

JSON-LD tests adding credentialSubject.id #853

Closed nodlesh closed 3 months ago

nodlesh commented 3 months ago

This PR fixes a check on for the verification of a proof where it was only getting checked for revokable credentials.

It also fixes the failure of JSON-LD tests that, once the fix above where made, failed to be verified. As recommended by ACAPy maintainers the credentialSubject.id was added to the credential when issued. This id is a did created by the holder.

ACA-Py runsets have been executed to check for side effects of these changes.