search

openwallet-foundation / owl-akrida

Apache License 2.0
3 stars 16 forks source link

feat: add env variable WITH_MEDIATION #11

Closed anwalker293 closed 1 year ago

anwalker293 commented 1 year ago
  1. Added env variable WITH_MEDIATION everywhere
  2. How come we have two docker-compose files? (Regular vs. dev?) Can we delete the dev one/do we still need it sticking around?
  3. mediatorPing didn't have ANY mediation in it ....

This shouldn't break anything, still need to test though

anwalker293 commented 1 year ago

All good to go! / Tested!

KimEbert42 commented 1 year ago

  1. Added env variable WITH_MEDIATION everywhere

    1. How come we have two docker-compose files? (Regular vs. dev?) Can we delete the dev one/do we still need it sticking around?

The dev build allows for real time changes to files without having to rebuild the docker container, but may not be suitable for deployment in some environments

3. mediatorPing didn't have ANY mediation in it ....

Mediator Ping assumes the default, withMediation=True.

This shouldn't break anything, still need to test though