openwallet-foundation / owl-akrida

Apache License 2.0
3 stars 16 forks source link

Issues with the Quick Start #66

Closed anwalker293 closed 3 months ago

anwalker293 commented 3 months ago

Currently investigating, but wanted to document the error here

32.52 In file included from /load-agent/load-agent/node_modules/node-addon-api/napi.h:2725,
32.52                  from ../src/ffi.h:2,
32.52                  from ../src/ffi.cc:3:
32.52 /load-agent/load-agent/node_modules/node-addon-api/napi-inl.h: In instantiation of 'napi_status Napi::details::AttachData(napi_env, napi_value, FreeType*, napi_finalize, void*) [with FreeType = Napi::details::CallbackData<void (*)(const Napi::CallbackInfo&), void>; napi_env = napi_env__*; napi_value = napi_value__*; napi_finalize = void (*)(napi_env__*, void*, void*)]':
32.52 /load-agent/load-agent/node_modules/node-addon-api/napi-inl.h:1965:39:   required from 'napi_status Napi::CreateFunction(napi_env, const char*, napi_callback, CbData*, napi_value__**) [with CbData = Napi::details::CallbackData<void (*)(const Napi::CallbackInfo&), void>; napi_env = napi_env__*; napi_callback = napi_value__* (*)(napi_env__*, napi_callback_info__*); napi_value = napi_value__*; napi_callback_info = napi_callback_info__*]'
32.52 /load-agent/load-agent/node_modules/node-addon-api/napi-inl.h:2021:38:   required from 'static Napi::Function Napi::Function::New(napi_env, Callable, const char*, void*) [with Callable = void (*)(const Napi::CallbackInfo&); napi_env = napi_env__*]'
32.52 ../src/ffi.cc:60:50:   required from here
32.52 /load-agent/load-agent/node_modules/node-addon-api/napi-inl.h:63:47: error: invalid conversion from 'napi_finalize' {aka 'void (*)(napi_env__*, void*, void*)'} to 'node_api_nogc_finalize' {aka 'void (*)(const napi_env__*, void*, void*)'} [-fpermissive]
32.52    63 |   status = napi_add_finalizer(env, obj, data, finalizer, hint, nullptr);
32.52       |                                               ^~~~~~~~~
32.52       |                                               |
32.52       |                                               napi_finalize {aka void (*)(napi_env__*, void*, void*)}
32.52 In file included from /root/.cache/node-gyp/18.20.4/include/node/node_api.h:12,
32.52                  from /load-agent/load-agent/node_modules/node-addon-api/napi.h:4,
32.52                  from ../src/ffi.h:2,
32.52                  from ../src/ffi.cc:3:
32.52 /root/.cache/node-gyp/18.20.4/include/node/js_native_api.h:516:43: note:   initializing argument 4 of 'napi_status napi_add_finalizer(napi_env, napi_value, void*, node_api_nogc_finalize, void*, napi_ref__**)'
32.52   516 |                    node_api_nogc_finalize finalize_cb,
32.52       |                    ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
32.52 make: *** [ffi_bindings.target.mk:126: Release/obj.target/ffi_bindings/src/ffi.o] Error 1
32.52 make: Leaving directory '/load-agent/load-agent/node_modules/ffi-napi/build'
32.52 gyp ERR! build error
32.52 gyp ERR! stack Error: `make` failed with exit code: 2
32.52 gyp ERR! stack     at ChildProcess.onExit (/load-agent/load-agent/node_modules/node-gyp/lib/build.js:194:23)
32.52 gyp ERR! stack     at ChildProcess.emit (node:events:517:28)
32.52 gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:292:12)
32.52 gyp ERR! System Linux 5.15.49-linuxkit-pr
32.52 gyp ERR! command "/usr/bin/node" "/load-agent/load-agent/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
32.52 gyp ERR! cwd /load-agent/load-agent/node_modules/ffi-napi
32.52 gyp ERR! node -v v18.20.4
32.52 gyp ERR! node-gyp -v v8.4.1
32.52 gyp ERR! not ok
32.52 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
------
failed to solve: process "/bin/sh -c yarn install" did not complete successfully: exit code: 1
swcurran commented 3 months ago

I recall there were a number of napi related issues reported with credo-ts. Perhaps this issue / PR might help? https://github.com/openwallet-foundation/credo-ts/issues/1621. Or I’m wasting your time…. ¯_(ツ)_/¯

anwalker293 commented 3 months ago

Yes! Just made a PR for this now :) https://github.com/hyperledger/aries-akrida/pull/67

KimEbert42 commented 3 months ago

This appears to be fixed. Closing.