search

openwallet-foundation / project-proposals

This repository will be used for OpenWallet Foundation project proposals. It will contain the proposal template and projects that have been proposed for consideration to the OpenWallet Foundation TAC.
Creative Commons Attribution 4.0 International
20 stars 36 forks source link

Pure Swift library for iOS to create VCs #27

Closed gauravping closed 9 months ago

gauravping commented 9 months ago

Pure Swift package for creating Verifiable Credentials (VCs) in multiple formats. This library helps in creation and verification of VCs formatted as SD-JWT (https://datatracker.ietf.org/doc/draft-ietf-oauth-sd-jwt-vc/) and VC-JWT (https://identity.foundation/jwt-vc-presentation-profile/)

lukasjhan commented 9 months ago

Hi @gauravping,

This link: (https://identity.foundation/jwt-vc-presentation-profile/) seems to be broken. If you look https://github.com/decentralized-identity/jwt-vc-presentation-profile, the link itself seems to be fine, but has the page disappeared?

gauravping commented 9 months ago

@lukasjhan - Thanks for pointing that out. I must have referenced that document no more than a week ago. Let me track that down and update this document and PR accordingly.

skounis commented 9 months ago

@gauravping It looks like the new file is created in the repository's root folder. Can we please move it under the projects folder?

https://github.com/openwallet-foundation/project-proposals/tree/main/projects

skounis commented 9 months ago

@gauravping The commits are incorrectly signed. Could you please check point "4. Commit your changes with proper sign-off" and section Fixing DCO on Existing Repositories" in the readme file?

gauravping commented 9 months ago

@skounis - First time contributor mistakes. Thanks for all the references. Would you recommend restarting the PR with a fresh fork?

tkuhrt commented 9 months ago

@skounis - First time contributor mistakes. Thanks for all the references. Would you recommend restarting the PR with a fresh fork?

You can either do that or you can follow the instructions under the DCO details - Rebase section to fix the existing commits with the DCO signoff.

gauravping commented 9 months ago

Hi @gauravping,

This link: (https://identity.foundation/jwt-vc-presentation-profile/) seems to be broken. If you look https://github.com/decentralized-identity/jwt-vc-presentation-profile, the link itself seems to be fine, but has the page disappeared?

@lukasjhan - The link has been restored. There was some update on the DIF website which caused that link to disappear.

tkuhrt commented 9 months ago

Unanimously approved by the TAC at the January 24, 2024 meeting