openwallet-foundation / sd-jwt-js

A JavaScript implementation of the Selective Disclosure JWT (SD-JWT) spec.
https://sdjwt.js.org/
Apache License 2.0
44 stars 13 forks source link

bug: Replace object with Extensible #182

Closed cre8 closed 8 months ago

cre8 commented 8 months ago

some type are using the object type to extend a type like type DisclosureFrame<T extends object> = Frame<T>;

This could be the reason for some errors we have in the veramo implementation. One of their devs suggested to use an extensible like

interface Extensible {
  [key: string]?: unknown;
}

type DisclosureFrame<T extends Extensible> = Frame<T>;
lukasjhan commented 8 months ago

I don't think it will affect other parts. So Let's give it a try. I think it would be okay to distribute it with the next tag and then check how does it go.

cre8 commented 8 months ago

I addressed it in #183

lukasjhan commented 8 months ago

Can we close this issue? @cre8