openwallet-foundation / sd-jwt-js

A JavaScript implementation of the Selective Disclosure JWT (SD-JWT) spec.
https://sdjwt.js.org/
Apache License 2.0
44 stars 13 forks source link

Resolve issues on sd-jwt-ts repository #84

Open berendsliedrecht opened 9 months ago

berendsliedrecht commented 9 months ago

As we will merge these two libraries, there will likely be some issues transferred as well from berendsliedrecht/sd-jwt-ts. These issues should be resolved in this repository (https://github.com/berendsliedrecht/sd-jwt-ts/issues). I can check out if they actually transfer and reopen an issue here.

lukasjhan commented 9 months ago

Good.

I think these issues are need to be processed:

https://github.com/berendsliedrecht/sd-jwt-ts/issues/14 https://github.com/berendsliedrecht/sd-jwt-ts/issues/15

lukasjhan commented 9 months ago

I'm currently processing merging sd jwt vc features. I'm not sure how many features should be provided. The standard is quite simple(version 01).

Maybe we should focus the actual usage from Credo and Veramo

berendsliedrecht commented 9 months ago

If we get feature parity with https://github.com/berendsliedrecht/sd-jwt-ts then it'll work with credo and that should be the first goal, yes. However, we can make some improvements and fixes where needed.