search

openwashdata-dev / washr

Assist the development of openwashdata data packages
Other
1 stars 0 forks source link

generated README appears an NA dataset in the summary table #7

Open mianzg opened 1 week ago

mianzg commented 6 days ago

Not a bug from the functions.

It can be various reasons, but essentially, the developers manually modified the dictionary csvfile at the bottom. There should be no newlines at the bottom of the file. Maybe add a sanity check on dictionary.csv in future version

larnsce commented 4 days ago

Yes, that could be a good case for using a testing function of the testthat R package: https://github.com/r-lib/testthat

mianzg commented 4 days ago

It cannot be tested because the bad result is not from the washr functions