search

openweave / openweave-wdlc

This package makes available the Weave Data Language (WDL) compiler (WDLC). WDL is Weave's publish and subscribe schema language. The WDLC compiler can be used to compile (i.e., validate and code generate) schema written against the WDL specification.
https://openweave.io/
Apache License 2.0
2 stars 8 forks source link

plugin.proto file is not crucial part for wdlc compilation #7

Closed yunhanw-google closed 5 years ago

yunhanw-google commented 5 years ago

debian libprotobuf-dev contains the development headers and static libraries needed for writing c++ applications, Includes well known proto type files, but the schema/plugin.proto is missing. In contrast, in upstream GitHub link(https://github.com/protocolbuffers/protobuf/releases/download/v3.6.1/protoc-3.6.1-linux-x86_64.zip), it has included plugin.proto file.

currently wdlc is checking plugin.proto file for compilation, without it, the compilation would fail. In fact, the wdlc should be compiled without plugin.proto.

Can you remove this plugin.proto check in code?

gerickson commented 5 years ago

I'll take a look at effecting a check for a different file.

gerickson commented 5 years ago

See https://github.com/openweave/openweave-wdlc/pull/8.