search

openwebwork / pg

Problem rendering engine for WeBWorK
http://webwork.maa.org/wiki/Category:Authors
Other
46 stars 76 forks source link

Add an en-GB localization file. #1109

Closed drgrice1 closed 3 weeks ago

drgrice1 commented 1 month ago

This isn't exactly needed, but is added for consistency. As for webwork2, translation isn't really needed in the .po file. However, if someone wants to do so it could be done.

Note that the en.po file was updated as well. This file hasn't been updated for a while since it really doesn't need to be.

drgrice1 commented 1 month ago

Yeah, this is just for completeness. Also, I think it would be an error if the file did not exist and the language was selected when a problem renders.

somiaj commented 1 month ago

I did test a few problems and got no errors, so that at least is good.

somiaj commented 1 month ago

FWIW, it seems using en-GB in webwork without this applied still works without any error when rendering problems, so looks like maketext just returns the inputted string without any error if given localization which doesn't have a .po file.

pstaabp commented 4 weeks ago

If anyone else is testing this, you also need to checkout openwebwork/webwork2#2553