search

openwebwork / webwork2

Course management front end for WeBWorK
http://webwork.maa.org/wiki/Main_Page
Other
146 stars 165 forks source link

should we comment out an extraneous call to mathview_scripts() in FileManager.pm ??? #142

Closed mgage closed 11 years ago

mgage commented 11 years ago

at line 556 of FileManager.pm

print $self->mathview_scripts();

should be commented out. Mathview is not needed in FileManager.pm and never was. it's a little confusing why this was here when mathview was first added.

It causes an error in the develop branch (no problem yet seen in the master branch).

mathview_scripts used to be defined in ContentGenerator.pm and inherited. It's not clear to me if this subroutine is defined at all anymore.

Geoff -- any comments on this? You reworked mathview a month or so ago.

jpgravel commented 11 years ago

We had a problem with it yesterday and commented it out. After a "find . | xargs grep 'string' -sl" we haven't found any implementation in any webwork file. So I suppose that it's not needed.

Jean-Philippe Gravel, ing. CSDP Certifié RFID Pro Président chez Gravel Innovation Inc. www.girfid.com Tél.: (418) 696-5688 SF: (866) 715-7733

2013/8/19 Michael Gage notifications@github.com

at line 556 of FileManager.pm

print $self->mathview_scripts();

should be commented out. Mathview is not needed in FileManager.pm and never was. it's a little confusing why this was here when mathview was first added.

It causes an error in the develop branch (no problem yet seen in the master branch).

mathview_scripts used to be defined in ContentGenerator.pm and inherited. It's not clear to me if this subroutine is defined at all anymore.

Geoff -- any comments on this? You reworked mathview a month or so ago.

— Reply to this email directly or view it on GitHubhttps://github.com/openwebwork/webwork2/issues/142 .

goehle commented 11 years ago

I got rid of the mathview_scripts subroutine, since nothing sets up scripts in that way. I wanted to keep things consistent by putting all of the javascript calls in output_JS functions. I never thought to check and see if it was called anywhere but Problem.pm and GatewayQuiz.pm.

Its possible that having mathview in the file manager is a holdover from when mathview was intended to be a dual purpose equation editor and latex editor. I removed most of the latex editing capabilities (or rather didn't upgrade them), though. So I see no reason why it should be in FileManager.

goehle commented 11 years ago

Dealth with in pull 143