search

openwebwork / webwork2

Course management front end for WeBWorK
http://webwork.maa.org/wiki/Main_Page
Other
143 stars 165 forks source link

Rename several pages #2265

Closed Alex-Jordan closed 9 months ago

Alex-Jordan commented 9 months ago

This makes more name changes discussed at #1992.

'Homework Sets'      => 'Assignments',
'User Settings'      => 'Account Settings',
'User Manager'       => 'Accounts Manager'
'Set Assigner'       => 'Assigner Tool',
'Set Manager'        => 'Sets Manager',
'Achievement Editor' => 'Achievements Manager'

It also changes the order of nav items a little, moving "Assigner Tool" (formerly "Set Assigner") higher up.

Lastly, while reviewing all the places to make name changes, I found a few vestiges of previous names that had never been changed.

somiaj commented 9 months ago

I don't like the "Assigner Tool" is currently between "Accounts Manager" and "Sets Manager". I'm okay with it being after those two as well, but it is currently between them which is taking me a while to get use to.

If that isn't a good place for others, maybe leave position alone in this PR and only focus on renaming.

Alex-Jordan commented 9 months ago

I'll move it to fourth after Instructor Tools, Accounts Manager, and Sets Manager.

Any preference on the order of Accounts Manager and Sets Manager?

Should Sets Manager be Assignments Manager? I avoided that for being too long, but we do have Achievements Manager already, which is longer

On Mon, Nov 27, 2023, 7:45 AM Jaimos Skriletz @.***> wrote:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3132feb7-454455534531-ce4e06aed06a70a9&q=1&e=cd7dcf61-fd6d-4e6c-8ab6-2f22a9ab0a14&u=https%3A%2F%2Fgithub.com%2Fopenwebwork%2Fwebwork2%2Fpull%2F2265%23pullrequestreview-1750761434, or unsubscribe https://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3132feb7-454455534531-b9583455c518980d&q=1&e=cd7dcf61-fd6d-4e6c-8ab6-2f22a9ab0a14&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABEDOAHEEIKYAKPDZJ76T7DYGSYRDAVCNFSM6AAAAAA73PJZ6KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJQG43DCNBTGQ . You are receiving this because you authored the thread.Message ID: @.***>

Alex-Jordan commented 9 months ago

Actually I am starting to think of a Set as what we have always thought of it. And an Assignment as a Set in context of being assigned to a user. So Sets Manager seems right.

On Mon, Nov 27, 2023, 8:12 AM Alex Jordan @.***> wrote:

I'll move it to fourth after Instructor Tools, Accounts Manager, and Sets Manager.

Any preference on the order of Accounts Manager and Sets Manager?

Should Sets Manager be Assignments Manager? I avoided that for being too long, but we do have Achievements Manager already, which is longer

On Mon, Nov 27, 2023, 7:45 AM Jaimos Skriletz @.***> wrote:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3132feb7-454455534531-ce4e06aed06a70a9&q=1&e=cd7dcf61-fd6d-4e6c-8ab6-2f22a9ab0a14&u=https%3A%2F%2Fgithub.com%2Fopenwebwork%2Fwebwork2%2Fpull%2F2265%23pullrequestreview-1750761434, or unsubscribe https://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3132feb7-454455534531-b9583455c518980d&q=1&e=cd7dcf61-fd6d-4e6c-8ab6-2f22a9ab0a14&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABEDOAHEEIKYAKPDZJ76T7DYGSYRDAVCNFSM6AAAAAA73PJZ6KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJQG43DCNBTGQ . You are receiving this because you authored the thread.Message ID: @.***>

Alex-Jordan commented 9 months ago

There are comments on lines 238 and 516 of conf/localOverrides.conf.dist that refer to the "homework sets editor".

Do I understand right that both of these should be referring to the Library Browser?

drgrice1 commented 9 months ago

There are comments on lines 238 and 516 of conf/localOverrides.conf.dist that refer to the "homework sets editor".

Do I understand right that both of these should be referring to the Library Browser?

Both of those lines actually apply to both the Library Browser and the Set Detail page. Although the $pg{displayModes} really applies to a lot more than just those pages and is a course configuration option.

Alex-Jordan commented 9 months ago

I am replacing lots of these words/phrases with the approach that it is an "assignment" if it's in the context of something that has been assigned to a user. Otherwise, it is a "set". Does that sound OK?

Alex-Jordan commented 9 months ago

Both of those lines actually apply to both the Library Browser and the Set Detail page.

I see how line 238 applies to both. But line 516 is about set definition search depth. How does that apply to Set Detail?

drgrice1 commented 9 months ago

I am replacing lots of these words/phrases with the approach that it is an "assignment" if it's in the context of something that has been assigned to a user. Otherwise, it is a "set". Does that sound OK?

Sounds good to me.

drgrice1 commented 9 months ago

I see how line 238 applies to both. But line 516 is about set definition search depth. How does that apply to Set Detail?

The search depth is also used for the import sets drop-down on the sets manager page. Your right, not the set detail page. However, that was the homework sets editor.