search

openwebwork / webwork2

Course management front end for WeBWorK
http://webwork.maa.org/wiki/Main_Page
Other
145 stars 165 forks source link

Fix filtering the user list by permission level or status for other languages. #2268

Closed drgrice1 closed 10 months ago

drgrice1 commented 10 months ago

Currently when filtering by permission level or status the text entered in the "Filter by what text?" field is matched against the untranslated permission level name or status name. As a result other languages must enter the English names for these to match what is displayed translated which is probably very confusing. This just matches against the translated names.

This fixes issue #1093.

dlglin commented 10 months ago

It would be nice if when filtering by a column with a fixed list of choices the user was given a drop-down of the available choices rather than having to type them. For the Classlist Editor (I forget the new name) this would apply to permission level and status, but this is beyond the scope of this PR.

drgrice1 commented 10 months ago

Yeah, I was thinking the same thing, but I just wanted to close that relatively old issue!

taniwallach commented 10 months ago

This change will take getting used to for non-English users who got used to filtering using the English permission levels. I recommend matching on both the English string and the translated string. That is an extra string match, but will not break what works at present for staff in non-English courses. Once there is a move to a pull-down menu - using only the translated string seems OK to me.

drgrice1 commented 10 months ago

I updated the pull request to compare to both the translated and untranslated strings. I actually initially implemented it this way, but decided to instead only use the translated string because that is what is visible to the end user. So this is just for old timers that are stuck in their ways!