search

openwebwork / webwork2

Course management front end for WeBWorK
http://webwork.maa.org/wiki/Main_Page
Other
141 stars 164 forks source link

Share strict to the PG safe zone. #2308

Closed drgrice1 closed 6 months ago

drgrice1 commented 6 months ago

Versions of Perl prior to 5.34 need this. Otherwise warnings are issue by the BEGIN { strict->import } approach now used in place of the old BEGIN { be_strict() } approach.

This fixes the issue reported in https://github.com/openwebwork/pg/pull/968#issuecomment-1910760107.

Alex-Jordan commented 6 months ago

This cleared up the warnings I was getting.

Others already tested the and did not have the issue with the warnings. So they are most likely already on perl 5.36. I guess they could use perlbrew to test this, but what do you think about me just merging this without a second approval?

drgrice1 commented 6 months ago

That should be okay.