This replaces the conf/site.conf file by adding many configuration variables to conf/webwork2.mojolicious.yml.
The idea is that many of the server configurations shouldn't be overridden by course configuration in site.conf or simple.conf. How this happens is that the new order of configurations reads is:
webwork2.mojolicious.yml is loaded and some basic configuration is done.
defaults.config
localOverrides.conf
simple.conf
course.conf
Configuration variables that shouldn't be overriden are then copied from webwork2.mojolicious.yml to CourseEnvironment.
Note that the URL and directory structure is now included in webwork2.mojolicious.yml so that has been removed from defaults.config.
Since yaml files cannot contain code, the loading of webwork2.mojolicious.yml is not done in the safe compartment.
Also, the code in conf/database.conf.dist has been moved to lib/WeBWorK/DB/Utils.pm -- This can be moved elsewhere if there is a better place for it. This was removed because it doesn't appear that there are the options that we used to allow in earlier versions.
Another strange thing that I noticed that when the session times out, I couldn't log back in. The addition of including the password on line 362 of lib/WeBWorK/Authen.pm fixed this, but I can't figure out how this work has changed that, but also, why the password was missing from that block.
Some other ideas I've thought about:
If this bloats webwork2.mojolicious.yml, we can move much of this to a different yaml file.
Move other settings from defaults.config to yaml files that wouldn't need to be loaded in the Safe
Move some of the items in the CourseEnvironment into the Mojolicious Controller config object or other helpers. Note: @drgrice1 suggested this, but will require rewriting a bunch of the codebase for a new location.
This replaces the
conf/site.conf
file by adding many configuration variables toconf/webwork2.mojolicious.yml
.The idea is that many of the server configurations shouldn't be overridden by course configuration in
site.conf
orsimple.conf
. How this happens is that the new order of configurations reads is:webwork2.mojolicious.yml
is loaded and some basic configuration is done.defaults.config
localOverrides.conf
simple.conf
course.conf
webwork2.mojolicious.yml
to CourseEnvironment.Note that the URL and directory structure is now included in
webwork2.mojolicious.yml
so that has been removed fromdefaults.config
.Since yaml files cannot contain code, the loading of
webwork2.mojolicious.yml
is not done in the safe compartment.Also, the code in
conf/database.conf.dist
has been moved tolib/WeBWorK/DB/Utils.pm
-- This can be moved elsewhere if there is a better place for it. This was removed because it doesn't appear that there are the options that we used to allow in earlier versions.Another strange thing that I noticed that when the session times out, I couldn't log back in. The addition of including the password on line 362 of
lib/WeBWorK/Authen.pm
fixed this, but I can't figure out how this work has changed that, but also, why the password was missing from that block.Some other ideas I've thought about:
webwork2.mojolicious.yml
, we can move much of this to a different yaml file.defaults.config
to yaml files that wouldn't need to be loaded in the Safeconfig
object or other helpers. Note: @drgrice1 suggested this, but will require rewriting a bunch of the codebase for a new location.