Line 53 of templates/ContentGenerator/CourseAdmin.html.ep was deleted. That line should not exist. That saves a list of all courses to the @courseIDs variable that is never used. The listCourses method is called again on line 56 (now 55).
On line 56 (now 55) of that same file, the admin course is omitted from the listing. This is how it used to be, and was removed in #2295. I don't believe that the admin course should be listed on the admin course listings page.
On line 110 of templates/ContentGenerator/CourseAdmin/add_course_form.html.ep the admin course is kept in the listing. This is the list of courses that can be copied. This was how it was set up in #2295, but was reverted in #2290 (probably in merge resolution, or maybe my changes to that pull request?). The intent was to allow the admin course to be copied to change to a new course to use for the admin course.
The first line changed is not controversial, but the second two are up for discussion.
There are three lines of code changed.
Line 53 of
templates/ContentGenerator/CourseAdmin.html.epwas deleted. That line should not exist. That saves a list of all courses to the@courseIDsvariable that is never used. ThelistCoursesmethod is called again on line 56 (now 55).On line 56 (now 55) of that same file, the admin course is omitted from the listing. This is how it used to be, and was removed in #2295. I don't believe that the admin course should be listed on the admin course listings page.
On line 110 of
templates/ContentGenerator/CourseAdmin/add_course_form.html.epthe admin course is kept in the listing. This is the list of courses that can be copied. This was how it was set up in #2295, but was reverted in #2290 (probably in merge resolution, or maybe my changes to that pull request?). The intent was to allow the admin course to be copied to change to a new course to use for the admin course.The first line changed is not controversial, but the second two are up for discussion.