openwebwork / webwork2

Course management front end for WeBWorK
http://webwork.maa.org/wiki/Main_Page
Other
141 stars 164 forks source link

let instructor's change course title #2354

Closed Alex-Jordan closed 3 months ago

Alex-Jordan commented 4 months ago

This makes some changes to the Course Config module so that in addition to course environment variables, settings from the course's _setting table in the database can be set. Then it applies this possibility to the course title.

The upshot is an instructor can visit Course Config and change the course title on their own now. Previously the only way to update the course title is to have the WW admin use the admin course to do that (or otherwise do it from the command line).

dlglin commented 4 months ago

I'm wondering if there needs to be a way to disable this. Will there be scenarios where an instructor should not be allowed to change the course name?

Alex-Jordan commented 4 months ago

You wrote course "name", but I want to be clear this is the course title. It's not the course ID that appears in urls, course files folder paths, etc. I believe it only appears at the top of the assignments page, and possibly as the html title for pages.

On Mon, Mar 11, 2024, 9:55 AM Danny Glin @.***> wrote:

I'm wondering if there needs to be a way to disable this. Will there be scenarios where an instructor should not be allowed to change the course name?

— Reply to this email directly, view it on GitHub https://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3132feb7-454455534531-d532066261ee0e05&q=1&e=bc4132d3-6a2f-460d-90d0-d3c8c760ce14&u=https%3A%2F%2Fgithub.com%2Fopenwebwork%2Fwebwork2%2Fpull%2F2354%23issuecomment-1988949727, or unsubscribe https://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3132feb7-454455534531-951f55ea81dd86f6&q=1&e=bc4132d3-6a2f-460d-90d0-d3c8c760ce14&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABEDOAEQV3VXVXUKKRO5GOLYXXV2LAVCNFSM6AAAAABEPPUM3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBYHE2DSNZSG4 . You are receiving this because you authored the thread.Message ID: @.***>

dlglin commented 4 months ago

Yes, I meant course title. I'm envisioning a scenario where an institution wants to insist that the course title match the official name of the course in their calendar, or perhaps a WW administrator includes section information in the course title and doesn't want an instructor to remove this.

I don't know if these are real use cases, so I'm asking whether it's worth the extra work to have a configuration option to disable this feature or have a permission associated with it.

Alex-Jordan commented 3 months ago

OK, I fixed the help issue @drgrice1 found, and I added permission level for being able to do this.

pstaabp commented 3 months ago

Just to test the permissions, I added

$pemissionLevels{setting_table_courseTitle}      = 'admin';

to localOverrides.conf

and still was able to change the courseTitle. Am I missing something here?

drgrice1 commented 3 months ago

The permission setting seems to be working for me. Are you sure that the user you are testing with is not an admin user?

pstaabp commented 3 months ago

Silly typo.