search

openwebwork / webwork2

Course management front end for WeBWorK
http://webwork.maa.org/wiki/Main_Page
Other
141 stars 164 forks source link

new Student Orientation #2358

Closed Alex-Jordan closed 3 months ago

Alex-Jordan commented 3 months ago

This removes "set0", the "MAATutorial" set, and the "Orientation" set from the distribution model course. I find most of the content there out of step with modern webwork2. If people want to keep those, I can change that part of this PR.

The main thing is this also adds a "Student Orientation" set, keeping all the files centrally in webwork2/assets/pg/ so this can be maintained with the distribution and not propagate as content in courses that get copied from term to term.

The new student orientation has a problem (number 3) that displays content contingent upon whether MathQuill, MathView, or neither is in use. Suggestions welcome for improving this orientation, although those could always come in a later PR to make changes easier to assess.

To try this, it is not enough to check out the branch. You also need to update your modelCourse's templates folder to match the courses.dist/modelCourse/templates/ folder. Then create a new course, and import the Student Orientation set.

drgrice1 commented 3 months ago

Also, could you wrap the long lines in the added problems. Many of those problems have excessively long lines, and that makes it harder to read the source code. It doesn't matter for how PGML displays the rendered problem.

drgrice1 commented 3 months ago

One other thing. Also apply the PG perltidy to the added problems.

Alex-Jordan commented 3 months ago

Thanks for your review. All that you mentioned has been addressed, unless you would like something different in that place with about decimal precision.

Alex-Jordan commented 3 months ago

Thanks @somiaj, I made some changes based on your review.

drgrice1 commented 3 months ago

I will merge this now with two approvals.