Checking that the $sender->section is defined does not work. That method always returns something that is defined. Even if the value of the section is NULL in the database the $sender->section method returns the empty string. Furthermore, testing for section = '' does not work to return those for which the section is NULL in the database. As a result if feedback_by_section is enabled and the $sender does not have a section set, then the returned list will always be empty.
This is a minor issue since typically when feedback_by_section is enabled, the users sending emails will have sections (since that is the whole point). But the defined check is useless.
Checking that the
$sender->sectionis defined does not work. That method always returns something that is defined. Even if the value of thesectionis NULL in the database the$sender->sectionmethod returns the empty string. Furthermore, testing forsection = ''does not work to return those for which thesectionis NULL in the database. As a result iffeedback_by_sectionis enabled and the$senderdoes not have a section set, then the returned list will always be empty.This is a minor issue since typically when
feedback_by_sectionis enabled, the users sending emails will have sections (since that is the whole point). But thedefinedcheck is useless.