search

openwebwork / webwork2

Course management front end for WeBWorK
http://webwork.maa.org/wiki/Main_Page
Other
145 stars 165 forks source link

Disappearing quiz versions when updating the date for a user. #2419

Closed pstaabp closed 4 months ago

pstaabp commented 4 months ago

In short, if the date of a quiz is changed via the "Sets assigned to user" page can remove the versions of that quiz. This is the RC version of 2.19 -- just updated our production server. Here's the steps:

  1. Create a quiz, assign it to yourself, take the quiz

  2. Go to the "Sets assigned to YOU" page (via Accounts Manager) and locate the quiz. You should also see the version:

    image

  3. Change the date on the quiz (not the versioned quiz) and click "Save Changes".

  4. The versioned quiz will disappear:

image
stassenm commented 4 months ago

I will add that it is not necessary to change any dates. It is sufficient for step 3 to be simply "Save Changes." Even with no changes made, all versioned quizzes for that user are deleted.

drgrice1 commented 4 months ago

Yeah, this is kind of a bad bug. The quiz versions don't just disappear. They are deleted.

pstaabp commented 4 months ago

Fixed by #2421

Alex-Jordan commented 4 months ago

IIRC, I started the redesign of that page and Glenn made it better. I'm sorry if it was my doing!

We've been using the develop branch since late March (or essentially what it was at that time) and had not run into this. Yesterday I applied the patch @drgrice1 made. This morning I have a report of missing quizzes, so naturally at first I thought I messed something up with applying the patch. But it seems clear now that one instructor lost some quizzes a little while ago and only reported it this morning. Testing directly, I am not able to make quizzes get deleted in this manner so I think the patch is definitely working.

drgrice1 commented 4 months ago

It is as much my fault as yours. I knew about the importance of the hidden inputs for versioned sets on that page, and that they need to be after the check boxes to work right. I should have seen this when those changes were made.

Hopefully your instructor did not lose important student quiz data.

Alex-Jordan commented 4 months ago

Hopefully your instructor did not lose important student quiz data.

The answer log captures enough to get the student grades accounted for. I'm not sure if there is any way to recover the problem seeds, but my impression is the instructor only needs the scores.