openwebwork / webwork2

Course management front end for WeBWorK
http://webwork.maa.org/wiki/Main_Page
Other
145 stars 165 forks source link

Fix unintentional versioned set deletion on the user detail page. #2421

Closed drgrice1 closed 4 months ago

drgrice1 commented 4 months ago

The issue is that with the restructuring of the page the hidden input corresponding to the "assigned" checkbox for a versioned set was not moved with the checkbox. As a result it now comes earlier in the DOM. This means that the order of the values for the hidden input and checkbox by the same name are now reversed in the submitted form. Since the WeBWorK::Controller param method returns the first one the code now gets the hidden input value of "delete" instead of the check box value of "assigned" even when the check box is checked.

The fix is simply to move the hidden input back to after the checkbox.

This fixes issue #2419.