search

openwebwork / webwork2

Course management front end for WeBWorK
http://webwork.maa.org/wiki/Main_Page
Other
140 stars 164 forks source link

Increase the required version of Mojolicious to 9.34. #2432

Closed drgrice1 closed 1 week ago

drgrice1 commented 3 weeks ago

This version added the encoding option to the Mojo::File::slurp method that is used in the WeBWorK::Utils::Files::readFile method.

An alternate approach to this pull request would be to not use the optional parameter to the Mojo::File::slurp method, and instead do the decoding ourselves. Then version 9.22 of Mojolicious (the version in the Ubuntu 22.04 repositories) could still be used.

drgrice1 commented 3 weeks ago

By the way, this is the fix for issue #2429.

drgrice1 commented 1 week ago

If at some point a newer version causes issues, then we will need to document installing a specific version. You can do this using cpanm with cpanm Mojolicious@9.37. However, at this point any version of Mojolicious that is version 9.34 or newer will work.

We also would need to implement a maximum version check in check_modules.pl.

drgrice1 commented 1 week ago

I also updated the docker build to use the latest version of Mojolicious from CPAN in this pull request now.

pstaabp commented 1 week ago

Also, requiring newer version of Mojolicious might be beneficial for other features. I don't know any right now, but this could be a reason to go this route instead of #2433.