Don't have Mojolicious UTF-8 decode files. Instead do it ourself.

openwebwork / webwork2

Course management front end for WeBWorK

http://webwork.maa.org/wiki/Main_Page

Other

140 stars 164 forks source link

Don't have Mojolicious UTF-8 decode files. Instead do it ourself. #2433

Closed drgrice1 closed 1 week ago

drgrice1 commented 3 weeks ago

In the WeBWorK::Utils::Files::readFile method UTF-8 decode the file contents after calling the Mojo::File::slurp without passing the UTF-8 decode parameter.

This is an alternate approach to #2432 that makes it so that version 9.22 of Mojolicious (the version in the Ubuntu 22.04 repositories) can still be used.

drgrice1 commented 3 weeks ago

Pick between #2432 and this pull request. Would we rather require a newer version of Mojolicious, or allow the older version to still work? Now taking votes. To rephrase the vote in terms of deprecation: Do we deprecate usage of Mojolicious 9.22 for webwork2?

dlglin commented 3 weeks ago

It's funny how you can affect the outcome of a vote just by the way you phrase the question.

RHEL 8 packages Mojolicious 8.42. Ubuntu 24.04 currently packages 9.35.

That means that RHEL users will need to install Mojolicious from CPAN regardless, and Ubuntu 24 users should be able to use the packaged version. Based on this I'm fine with requiring the newer version of Mojolicious.