openwebwork / webwork2

Course management front end for WeBWorK
http://webwork.maa.org/wiki/Main_Page
Other
141 stars 164 forks source link

when grade passback only happens on mass update intervals, let studen… #2455

Open Alex-Jordan opened 3 weeks ago

Alex-Jordan commented 3 weeks ago

…ts know

This is mainly so that when there is an LTI grade passback mode (course or homework) but $LTIGradeOnSubmit is false, there will be a message about how frequently grades are updated.

We have $LTIGradeOnSubmit false because for some students, having this true leads to D2L pinging them through their phone every time they submit a correct answer. But then I have been getting many messages from students this term who think something is broken because their grade in D2L is not matching the WW grade. (They just haven't waited the hour that we have $LTIMassUpdateInterval set to.)

This message will only help so much, since many students won't read it. But it is something.

Alex-Jordan commented 3 weeks ago

It also changes the generic "the LMS" to the actual name of the LMS when that name is not the default 'e.g., Blackboard, Canvas, Moodle, etc.'.

Alex-Jordan commented 3 weeks ago

I don't love how this code here does a check against the string 'e.g., Blackboard, Canvas, Moodle, etc.'.

One idea is to change the default to 'the LMS', or 'the Learning Management System'. I'm not sure if that's a good change for other places the name is used.

Another idea is to just allow the messages here so that they might come out like Your score was not successfully sent to e.g., Blackboard, Canvas, Moodle, etc.. (Although, note the double period there.)

Are either of these better than leaving this how it is?

drgrice1 commented 3 weeks ago

I didn't notice the check against the default string that was added. Yeah, I don't like that either. I would be fine with changing the default to "the LMS".

Alex-Jordan commented 2 weeks ago

I updated this to change the default LMS name the be "the LMS".