fix(bug): Missing icon on Linux

[compiuta]

closes #23

The issue with the icon not displaying correctly on linux was because of an incorrect icon path.

I found this https://stackoverflow.com/questions/30845416/how-to-go-back-1-folder-level-wih-dirname that helped solve our issue :smiley:

The __dirname node variable gives the current path of the javascript file we are in. In this case the __dirname was giving the path inside /src which we were then concatenating the /icon.ico to it. Since there is no icon.ico in this folder the icon was not showing up.

I am using ubuntu and as you can see the beautiful icon is now displaying properly :tada:

[adrienjoly]

Awesome! I'm gonna test that on macOS.

Before we merge, can you cancel you changes on the package-lock.json file, please? (unless they are required for this to work, of course)

EDIT: I confirm that the build still works on macOS after this change, and it fixes the icon from the launcher too! See the icon I used to see before that change:

=> Thank you for doing this!

[adrienjoly]

=> https://github.com/openwhyd/openwhyd-electron/releases/tag/v1.0.1 🎉

[compiuta]

@adrienjoly

The package-lock.json should not have been changed but for some reason my branch listed older versions of the dependencies :thinking:

You can definitely revert it to the previous version package-lock.json file to remove the changes made from my branch.

Let me know if you need me to open up a new pull request.

I can confirm that the icon is still working on linux with the original package-lock.json file

[adrienjoly]

It’s ok, I did it myself in a following commit, directly on master. Thank you for offering! V1.0.2 is out :-)

Le sam. 20 juin 2020 à 17:23, compiuta notifications@github.com a écrit :

@adrienjoly https://github.com/adrienjoly

The package-lock.json should not have been changed but for some reason my branch listed older version of the dependencies 🤔

You can definitely revert it the the previous version package-lock.json file to remove the changes made from my branch.

Let me know if you need me to open up a new pull request.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/openwhyd/openwhyd-electron/pull/29#issuecomment-647009204, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEB2RPZLGC6IYOWBZKHRWLRXTIADANCNFSM4ODAZLBQ .

-- Envoyé avec Gmail Mobile