Uninstalling active configuration doesn't work

riblo commented 9 years ago

After a configuration update in owm, uninstall.sh script try to execute:

uci changes openvpn | grep "=openvpn" | cut -d'.' -f2 | cut -d'=' -f1 | awk '{print "/var/run/openvpn-"$1".pid"}' | xargs cat | xargs kill uci changes openvpn | grep "=openvpn" | cut -d'.' -f2 | cut -d'=' -f1 | awk '{"rm /var/run/openvpn-"$1".pid"|getline;print}'

but the output is:

--- Tue Dec 2 15:51:02 CET 2014 ------------------

Installing new configuration Deploying new configuration Changing hostname Applying network configuration Creating tap v37t37 Tue Dec 2 15:51:02 2014 ERROR: Cannot ioctl TUNSETIFF v37t37: Device or resource busy (errno=16) Tue Dec 2 15:51:02 2014 Exiting due to fatal error [...]

This problem is due to openVPN init script, because there isn't longer avaliable: SERVICE_PID_FILE="/var/run/openvpn-$s.pid" and the daemon is started without option "--writepid "$SERVICE_PID_FILE".

claudyus commented 9 years ago

This commit (https://github.com/openwisp/openwrt/commit/7284c58125d47e0f9d241637adba442aa69e5467) fix the upstream bug.

Using this improvement in firmware result in

root@Uni_Alix:~# /tmp/owispmanager/uninstall.sh 
Removing l2 tc configuration
Stopping l2 vpn and removing their configuration
1797
Removing tap v48t48
Tue Dec  2 17:44:07 2014 TUN/TAP device v48t48 opened
Tue Dec  2 17:44:07 2014 Persist state set to: OFF
Stopping wifi and network and removing their configurations
Disabling bridge test
Restoring original wifi and network configurations
Interface test not found
Configuration un-installed

We could apply as workaround the correct openvpn file inside openwisp-fw/etc/init.d RFC!

claudyus commented 9 years ago

temporarily fix propose here https://github.com/openwisp/OpenWISP-Firmware/commit/5264038e49fa0d6a7e3521ba83c51316884d37cd

openwisp / OpenWISP-Firmware

Uninstalling active configuration doesn't work #23