openwisp / ansible-openwisp2

Ansible role that installs and upgrades OpenWISP.
https://openwisp.io/docs/dev/ansible/
BSD 3-Clause "New" or "Revised" License
477 stars 138 forks source link

[chore] Task name, variable and test changes for linting #395

Closed broadstack-au closed 2 years ago

broadstack-au commented 2 years ago

In the interest of reducing the amount of noise generated during role tests, all bar one item that triggered linting errors have been silenced.

The remaining warning is:

ignore-errors: Use failed_when and specify error conditions instead of using ignore_errors.
tasks/apt.yml:51 Task/Handler: set redis to listen on ipv4

which I left alone because I have no context around how to trigger it / when it would error / why this ignore was introduced.

If you'd prefer this change to happen differently, please let me know.

nemesifier commented 2 years ago

Thanks @broadstack-au :+1: