search

openwisp / ansible-openwisp2

Ansible role that installs and upgrades OpenWISP.
https://openwisp.io/docs/dev/ansible/
BSD 3-Clause "New" or "Revised" License
474 stars 136 forks source link

[fix] Corrected FreeRADIUS directory #461

Closed dim-0 closed 1 month ago

dim-0 commented 7 months ago

Modified freeradius_dir to include the 3.0/ directory

dim-0 commented 7 months ago

Fixes #398

pandafy commented 7 months ago

I think this is already handled here

https://github.com/openwisp/ansible-openwisp2/blob/ce426d33759db9e3d9ea5048521c226676473d88/tasks/freeradius.yml#L2-L32

dim-0 commented 7 months ago

Well, it looks like it should (line 29-32), but at least for me the ansible role still fails with the error message, that the directory /etc/freeradius/mods-available/sql does not exist (same as in first post in #398). When changing as suggested here, it will successfully processes.

Maybe the error is thrown a little earlier in the role execution, before it reaches the file you posted?

nemesifier commented 1 month ago

This change as is can't be accepted because it causes issues to systems which are using newer versions of freeradius. I am closing for now. Feel free to reopen supplying a patch that can work in all the supported cases. Thank you for contributing.