openwisp / ansible-openwisp2

Ansible role that installs and upgrades OpenWISP.
https://openwisp.io/docs/dev/ansible/
BSD 3-Clause "New" or "Revised" License
475 stars 137 forks source link

[bug/qa] Lint errors are ignored #485

Open nemesifier opened 1 month ago

nemesifier commented 1 month ago

Lint errors are ignored: https://github.com/openwisp/ansible-openwisp2/blob/master/molecule/local/molecule.yml#L9-L12

This was probably forgotten.

We need to move those checks from there to the run-qa-checks script, if there's no run-qa-checks script, we must add one like we have in other repos. We also need to make sure failing QA checks do not stop the entire build as we did in other modules, eg: https://github.com/openwisp/openwisp-controller/commit/5fff20c7f980007dc139c339891e452e76306401 (double check the latest version of the file for the latest optimal configuration).

We must not ignore failures and we must fix all the linting issues that are currently affecting this role.