Closed nikitaermishin closed 4 years ago
@nemesisdesign The problem is about providing base_url
to HTML
function. base_url
should provide absolute path to the folder, which contains our css
and js
files. I suppose we could do it by some better way (including fix of STATIC_URL
value mistake). So I can compose BATCH_PDF_TEMPLATE_BASE_URL
of absolute way to django_freeradius
folder and STATIC_URL
variable. Will provide commit soon, so you will have opportunity to understand what I am talking about. :smiley:
I think this
weasyprint>=43,<=44
should beweasyprint>=44,<45
@2stacks It has no other versions between 44
and 45
, so isn't that the same as weasyprint==44
? If so, could I use any of them?
I think this
weasyprint>=43,<=44
should beweasyprint>=44,<45
@2stacks It has no other versions between
44
and45
, so isn't that the same asweasyprint==44
? If so, could I use any of them?
Yes, they all achieve the same thing. However, if you look at the current file, my RFC is purely based on consistency. At some point 44 will be the supported lower bound and some future 4x will be the upper bound.
@nemesisdesign Ok, rebased my branch. Now working on the problem :smiley:
PS: please also rebase on the current master.
PR for improvement commit, which makes a migration from html2pdf to weasyprint. Changes:
weasyprint>=44
to requirements.txt instead ofxmtml2pdf
STATIC_URL
in tests/settings.py to compatible with weasyprintBATCH_PDF_TEMPLATE_BASE_URL
in django_freeradius/settings.pygenerate_pdf
function in django_freeradius/utils.py, now it works using weasyprint APICloses #243