Closed nepython closed 4 years ago
Totals | |
---|---|
Change from base Build 398: | 0.004% |
Covered Lines: | 578 |
Relevant Lines: | 579 |
@nemesisdesign, can you please review this :smile:
Is it me or does it get stuck on "Closing popup" on firefox when I try to change an existing IP's information?
Let me check this out.
@atb00ker, I have applied necessary changes suggested by you and taken care of the popup closing issue, though it seems I will have to add new test cases for the changes. Extremely sorry for replying so late, I had my exams going on so couldn't put in much time😅.
Sure, I am making new test cases for the same.
@nemesisdesign, can you please review this?:smile:
P.S: f-strings joined the party in Python 3.6 not 3.7 as I thought earlier, so I think we can use it everywhere! :smile:
Done :smiley:
Done
@nemesisdesign, can you please review this :smiley:
Great work @nepython. Now the goal should be that in your next patches you can get to this point with a lot less interaction and review on our side. That's why you should keep training.
Sure, @nemesisdesign will try to achieve that :)
Closes #101