search

openwisp / django-ipam

The development of this project has moved to openwisp-ipam
https://github.com/openwisp/openwisp-ipam
BSD 3-Clause "New" or "Revised" License
78 stars 28 forks source link

[subnet-visualizer] Allow to click on used ip to change them #103

Closed nepython closed 4 years ago

nepython commented 4 years ago

Closes #101

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 400

Totals Coverage Status
Change from base Build 398: 0.004%
Covered Lines: 578
Relevant Lines: 579
💛 - Coveralls
nepython commented 4 years ago

@nemesisdesign, can you please review this :smile:

nepython commented 4 years ago

Is it me or does it get stuck on "Closing popup" on firefox when I try to change an existing IP's information?

Let me check this out.

nepython commented 4 years ago

@atb00ker, I have applied necessary changes suggested by you and taken care of the popup closing issue, though it seems I will have to add new test cases for the changes. Extremely sorry for replying so late, I had my exams going on so couldn't put in much time😅.

nepython commented 4 years ago

Sure, I am making new test cases for the same.

nepython commented 4 years ago

@nemesisdesign, can you please review this?:smile:

atb00ker commented 4 years ago

P.S: f-strings joined the party in Python 3.6 not 3.7 as I thought earlier, so I think we can use it everywhere! :smile:

nepython commented 4 years ago

Done :smiley:

nepython commented 4 years ago

Done

nepython commented 4 years ago

@nemesisdesign, can you please review this :smiley:

nepython commented 4 years ago

Great work @nepython. Now the goal should be that in your next patches you can get to this point with a lot less interaction and review on our side. That's why you should keep training.

Sure, @nemesisdesign will try to achieve that :)