openwisp / django-ipam

The development of this project has moved to openwisp-ipam
https://github.com/openwisp/openwisp-ipam
BSD 3-Clause "New" or "Revised" License
78 stars 28 forks source link

[general] Minor fixes for extending django-ipam #47

Closed anurag-ks closed 6 years ago

anurag-ks commented 6 years ago

Small changes which were required while extending django-ipam into openwisp-ipam.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 134


Totals Coverage Status
Change from base Build 127: 0.0%
Covered Lines: 437
Relevant Lines: 439

💛 - Coveralls
anurag-ks commented 6 years ago

@nemesisdesign thankyou for the review, I had to add the the app_label because of this error - RuntimeError: Model class django_ipam.models.Subnet doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS., I will try to look for correct solution for this.

nemesifier commented 6 years ago

@anurag-ks take a look at what Rohith is doing, ask him questions if needed

anurag-ks commented 6 years ago

@nemesisdesign another thing I noticed is that when I add the OrgMixin or rather the organization field to the models, the test cases under openwisp-ipam fail. Since the organization field cannot be empty.