[qa] BaseSerializer Imported/Implemented

openwisp / django-ipam

The development of this project has moved to openwisp-ipam

https://github.com/openwisp/openwisp-ipam

BSD 3-Clause "New" or "Revised" License

78 stars 28 forks source link

[qa] BaseSerializer Imported/Implemented #58

Closed EdgeKing810 closed 5 years ago

EdgeKing810 commented 5 years ago

Imported BaseSerializer from https://github.com/openwisp/openwisp-utils/pull/13/ and removed validate method in serializers.py. Anything more I need to do?

closes #53

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 170

5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.1%) to 98.894%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
django_ipam/api/serializers.py	5	8	62.5%
<!--	Total:	5	8	62.5%	-->

Files with Coverage Reduction	New Missed Lines	%
django_ipam/base/models.py	2	98.33%
<!--	Total:	2		-->

Totals
Change from base Build 166:	-1.1%
Covered Lines:	447
Relevant Lines:	452

Pull Request Test Coverage Report for Build 190

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 166:	0.0%
Covered Lines:	446
Relevant Lines:	446

💛 - Coveralls

EdgeKing810 commented 5 years ago

Any help on how to get the coverage back to 100% again? :/

EdgeKing810 commented 5 years ago

Now I am getting an error in the travis build. Can someone help me to fix that error and give me some instructions on how to further proceed? Thanks. I'm relatively new to coverage things with python...

EdgeKing810 commented 5 years ago

After a loooong tiring day, I managed to do it. Please let me know of other things that I need to fix or improvements that I need to do.

EdgeKing810 commented 5 years ago

I'm still not really understanding what to do... Could you guide me a little more please?

EdgeKing810 commented 5 years ago

So... as far as I understood, all the files in django-ipam remains the same. Just in django_ipam/api/serializers.py, we pass ValidatedModelSerializer as the parameter then remove validate methods from other serializers files including this one. So to start with, how do I import ValidateModelSerializer from openwisp-utils?

Let me know if my understanding is correct.

EdgeKing810 commented 5 years ago

I don't know if I did it correctly this time. Please let me know...

EdgeKing810 commented 5 years ago

I didn't know that's all that needed to be done. Also, I was trying to keep the first line of the commit message short so as that it is readable without expanding. It's sure better now though.