openwisp / django-ipam

The development of this project has moved to openwisp-ipam
https://github.com/openwisp/openwisp-ipam
BSD 3-Clause "New" or "Revised" License
78 stars 28 forks source link

Master subnet validations (patched) #60

Closed shashwat1002 closed 5 years ago

shashwat1002 commented 5 years ago

Patches the work done in pull request #54 , so that it works for python 3.5 and also sorts out certain flake8 issues.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 193


Changes Missing Coverage Covered Lines Changed/Added Lines %
django_ipam/apps.py 14 17 82.35%
<!-- Total: 17 20 85.0% -->
Totals Coverage Status
Change from base Build 192: -0.6%
Covered Lines: 462
Relevant Lines: 465

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 194


Changes Missing Coverage Covered Lines Changed/Added Lines %
django_ipam/compat.py 14 17 82.35%
<!-- Total: 20 23 86.96% -->
Totals Coverage Status
Change from base Build 192: -0.6%
Covered Lines: 465
Relevant Lines: 468

💛 - Coveralls
nemesifier commented 5 years ago

@shashwat1002 great work, thanks! :+1:

See my improvements for future reference: https://github.com/openwisp/django-ipam/commit/a74ab5d115c2421007e3491a50394f6dac93af06