[qa] Avoid leaving test files after tests

openwisp / django-ipam

The development of this project has moved to openwisp-ipam

https://github.com/openwisp/openwisp-ipam

BSD 3-Clause "New" or "Revised" License

78 stars 28 forks source link

[qa] Avoid leaving test files after tests #61

Closed cking100 closed 5 years ago

cking100 commented 5 years ago

Fixes #59

cking100 commented 5 years ago

@nemesisdesign By default, the csv file is genearated inside parent directory itself. i tried changing that using MEDIA_ROOT and MEDIA_URL but that is not working. I think this is how its done in other repos as well so what may be the cause?

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 199

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.359%

Totals
Change from base Build 195:	0.0%
Covered Lines:	465
Relevant Lines:	468

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 202

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.359%

Totals
Change from base Build 195:	0.0%
Covered Lines:	465
Relevant Lines:	468

💛 - Coveralls

cking100 commented 5 years ago

@nemesisdesign A data_123... file is created in the main directory itself under ~/django-ipam/ and this file is used here https://github.com/openwisp/django-ipam/blob/a74ab5d115c2421007e3491a50394f6dac93af06/django_ipam/management/commands/__init__.py#L46 So, i think it is necessary to store it and i'm not sure but i think it is created by the system every time after running tests