search

openwisp / django-ipam

The development of this project has moved to openwisp-ipam
https://github.com/openwisp/openwisp-ipam
BSD 3-Clause "New" or "Revised" License
78 stars 28 forks source link

[qa] cleanup runflake8 and runisort #63

Closed 1871vinayak closed 5 years ago

1871vinayak commented 5 years ago

Cleaning up runisort and flake8 settings. GCI Task : https://codein.withgoogle.com/dashboard/task-instances/6061885926408192/

Closes #62

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 204

Changes Missing Coverage Covered Lines Changed/Added Lines %
django_ipam/compat.py 2 4 50.0%
<!-- Total: 3 5 60.0% -->
Totals Coverage Status
Change from base Build 203: 0.0%
Covered Lines: 465
Relevant Lines: 468
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 218

Totals Coverage Status
Change from base Build 203: 0.0%
Covered Lines: 465
Relevant Lines: 468
💛 - Coveralls
1871vinayak commented 5 years ago

Successfully Cleanup isort and flake8 settings in an OpenWISP module And my travis passed successfully

atb00ker commented 5 years ago

Okay. To begin with, squash all the commits and make 1 commit as per the guidelines here: http://openwisp.io/docs/developer/contributing.html?highlight=commit#commit-message-style-guidelines

atb00ker commented 5 years ago

One small thing: can you please add Closes <your-issue-number> in your pull request description. It links the issue with pull request. ( Useful to navigate )

1871vinayak commented 5 years ago

One small thing: can you please add Closes <your-issue-number> in your pull request description. It links the issue with pull request. ( Useful to navigate )

Done 👍

1871vinayak commented 5 years ago

Corrected the commit 👍 @atb00ker @nemesisdesign

1871vinayak commented 5 years ago

Thanks @nemesisdesign 😃