search

openwisp / django-ipam

The development of this project has moved to openwisp-ipam
https://github.com/openwisp/openwisp-ipam
BSD 3-Clause "New" or "Revised" License
78 stars 28 forks source link

[admin] Fixed auto-complete relations #75 #77

Closed pacicap closed 5 years ago

pacicap commented 5 years ago

Fortunately from Django 2.0 auto-complete is already intergrated. The relations to subnets were displayed as selects. When database becomes too populated loading all subnets becomes slow. Hence the need to implement auto-complete fields instead of selects.

Fixes #75

pacicap commented 5 years ago

sorry for the delay had some issues in getting started

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 271

Totals Coverage Status
Change from base Build 251: 0.0%
Covered Lines: 477
Relevant Lines: 477
💛 - Coveralls
pacicap commented 5 years ago

Oh oh sorry i will correct that thanks

On Tue, Feb 19, 2019, 18:21 Ajay Tripathi <notifications@github.com wrote:

@atb00ker approved this pull request.

Hello, looks good, thanks 👍 (P.S: You might want to check that local settings for git, the commit is not made by your name rather "root")

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openwisp/django-ipam/pull/77#pullrequestreview-205345857, or mute the thread https://github.com/notifications/unsubscribe-auth/Aax0WMqAsGnYvtz6Fck4YcLR7OECgcigks5vPDKKgaJpZM4a_BzR .

nemesifier commented 5 years ago

@pacicap do you want to still correct the email in your commit so you can appear in the list of contributors?

pacicap commented 5 years ago

Yes @nemesisdesign I will like to correct it.

pacicap commented 5 years ago

Correcting that Wright away

pacicap commented 5 years ago

@nemesisdesign i just corrected my commit name. sorry for the delay.