[Support] Django2.2 - Githubissues

openwisp / django-ipam

The development of this project has moved to openwisp-ipam

https://github.com/openwisp/openwisp-ipam

BSD 3-Clause "New" or "Revised" License

78 stars 28 forks source link

[Support] Django2.2 #80

Closed DaffyTheDuck closed 4 years ago

DaffyTheDuck commented 4 years ago

[Fix #78] Added support of django2.2 and updated djangorestframework

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 279

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 273:	0.0%
Covered Lines:	479
Relevant Lines:	479

💛 - Coveralls

DaffyTheDuck commented 4 years ago

Great work @IAmAMissingColon

The travis tests might be failing for irrelevant reasons but just to make sure, did you run the tests on your machine ./runtests.py ?

Also, a small nit-pick. The commit message should be [requirements] Added Support For Django2.2 and not [django-ipam] Added Support For Django2.2, you can change it with the help of the command git commit --amend.

./runtests.py is running without any error 😄

atb00ker commented 4 years ago

Added support of django2.2 and updated djangorestframework

I don't see the change for djangorestframework!

DaffyTheDuck commented 4 years ago

Added support of django2.2 and updated djangorestframework

I don't see the change for djangorestframework!

Actually, In the first commit I changed the djangorestframework vesrion, but later I decided to cancel it :sweat_smile:

Should I change it again ? Or just change the commit message ?

DaffyTheDuck commented 4 years ago

Thank You Sir :smiley: