openwisp / django-ipam

The development of this project has moved to openwisp-ipam
https://github.com/openwisp/openwisp-ipam
BSD 3-Clause "New" or "Revised" License
78 stars 28 forks source link

[bug] Javascript error on add subnet page #85

Closed atb00ker closed 4 years ago

atb00ker commented 4 years ago

I am seeing Uncaught SyntaxError: Unexpected token ',' on my browser console on the add new subnet page.

nemesifier commented 4 years ago

@atb00ker is this still happening with the latest master?

atb00ker commented 4 years ago

@nemesisdesign yes it's there. The "values" & "label" in data is not getting a value.

    vals[1] = Number(vals[1]);
    data = [
      {
        values: ,
        labels: ,
        text: vals,
atb00ker commented 4 years ago

I see this is fixed by #89 but a new error shows:

Uncaught TypeError: Cannot read property 'appendChild' of null
    at (index):403 - parent_element.appendChild(subnet_list);

Possibly this was hidden because of the previous error! :smile:

nepython commented 4 years ago

@atb00ker, has this issue been resolved?

Uncaught TypeError: Cannot read property 'appendChild' of null at (index):403 - parent_element.appendChild(subnet_list);

I tried to reproduce the errors, but was unable to do so: image

image

Though few warnings and errors were raised as can be seen, they were specific to Mozilla Firefox and the console on Chrome showed none of these warnings/errors. If anything else is needed to perform to reproduce the error please specify.:smile:

atb00ker commented 4 years ago

@nepython there have been a lot of fixes lately, if you don't see it, it's possible fixed in another commit recently. I'll double check and close it if it's not required! :smile:

atb00ker commented 4 years ago

Thanks for checking @nepython , I think it got fixed during GCI but the GCI student forgot to tag this issue number in the commit hence it's not closed! :smile:

nemesifier commented 4 years ago

thx for updating!