[enchancement] Added sqlite version check

openwisp / django-ipam

The development of this project has moved to openwisp-ipam

https://github.com/openwisp/openwisp-ipam

BSD 3-Clause "New" or "Revised" License

78 stars 28 forks source link

[enchancement] Added sqlite version check #86

Closed waleko closed 4 years ago

waleko commented 4 years ago

Resolves issue #81

Added a sqlite version check to prevent segmentation fault being raised.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 302

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 300:	0.0%
Covered Lines:	1968
Relevant Lines:	1968

💛 - Coveralls

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 301

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 99.441%

Totals
Change from base Build 300:	-0.6%
Covered Lines:	1957
Relevant Lines:	1968

💛 - Coveralls

atb00ker commented 4 years ago

I think a relevant fix here would be changing the travis version to fix the issue! (Like using bionic)

nemesifier commented 4 years ago

@atb00ker https://github.com/openwisp/django-ipam/blob/master/.travis.yml#L3

atb00ker commented 4 years ago

Oh, is this solved because the issue is closed but the last PR also had this Segmentation fault problem: https://travis-ci.org/openwisp/django-ipam/jobs/626999210?utm_medium=notification&utm_source=github_status

nemesifier commented 4 years ago

@atb00ker seems I merged both 12 days ago, on the same day. So the build was performed before I merged https://github.com/openwisp/django-ipam/pull/80 which contains the change to bionic.