search

openwisp / django-ipam

The development of this project has moved to openwisp-ipam
https://github.com/openwisp/openwisp-ipam
BSD 3-Clause "New" or "Revised" License
78 stars 28 forks source link

[models] NetworkField: fix conversion of None values #95

Closed okraits closed 4 years ago

okraits commented 4 years ago

Fixes #94

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 361

Changes Missing Coverage Covered Lines Changed/Added Lines %
django_ipam/base/fields.py 1 2 50.0%
<!-- Total: 1 2 50.0% -->
Totals Coverage Status
Change from base Build 357: -0.2%
Covered Lines: 492
Relevant Lines: 493
💛 - Coveralls
coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 362

Changes Missing Coverage Covered Lines Changed/Added Lines %
django_ipam/base/fields.py 1 2 50.0%
<!-- Total: 1 2 50.0% -->
Totals Coverage Status
Change from base Build 357: -0.2%
Covered Lines: 492
Relevant Lines: 493
💛 - Coveralls
okraits commented 4 years ago

@nemesisdesign Should I add a test for that?

okraits commented 4 years ago

@okraits that would be great! Can you?

I will try to come up with a test later today.

nemesifier commented 4 years ago

I'm merging since it's just one line but if you do find a way to test please send it

okraits commented 4 years ago

Ok - I just don't have the time to look into this now :cry: