Closed atb00ker closed 6 years ago
Since,
test_status_modified_after_change
in test_config.py, line 166
test_config_status_modified
in test_device.py , line 47
Already check the final result is correct or not, i didn't implement the tests,
i'll work on coverage. :smile:
Problem faced while implementing ondelta
:
_state.adding
value is always false
in the ondelta
functions.
def clean(self):
print(self._state.adding) # Output: True
...
def ondelta_[Field](self, old_value, new_value):
print(self._state.adding) # Output: False | [Expected: True]
...
To solve this, i created a new variable customStateAdding
in clean()
,
However if the ondelta()
is called before the clean()
the code breaks,
this might cause unintentional bugs.
thanks for trying @atb00ker. I appreciate the fact that you didn't want to push for changes that could cause unintentional bugs. If you're looking for more issues on which you can contribute, ping me
[Optimisation] In order to avoid extra query in the
clean()
indevice.py
&config.py
ondelta is integrated.Fixes #78